microsoft / WinDbg-Samples

Sample extensions, scripts, and API uses for WinDbg.
MIT License
702 stars 118 forks source link

Remove two assert statements #74

Closed alexsmendez closed 1 year ago

alexsmendez commented 1 year ago

This PR is to handle the following:

  1. The QEMU gdb server was sending a new target xml file (aarch64-pauth.xml), so the code was asserting since it does not handle such xml file. The fix will ignore a new target xml file sent by the GDB server, since currently, this assert was done to detect any new xml file that the ExdiGDbSrv client would handle, but it seems that this is causing a lot of support issues for things that we don't need it.
  2. The second issue is provoked also by an assert condition when the user provides an invalid format of the Ip:Port string, so the exdiGdbSrv client will exit rather than asserting.