[CoreText] Address multiple abandoned TODOs

[msft-Jeyaram]

There are few TODOs that are not being tracked in CoreText:

• [ ] DWriteWrapper_CTFont::473 // TODO: The symbolic traits below are poorly documented/have no clear DWrite mapping // kCTFontUIOptimizedTrait // kCTFontCompositeTrait

• [ ] DWriteWrapper_CTFont::477 // TODO: The upper 16 bits of symbolic traits describe stylistic aspects of a font, specifically its serifs, // such as modern, ornamental, or sans (no serifs) // DWrite has no such API for characterizing fonts

• [ ] DWriteWrapper_CoreText::202 // TODO:: // Note here we only look at attribute value at first index of the specified range as we can get a default font size to use here. ` // Per string range attribute handling will be done in _CreateDWriteTextLayout.

• [ ] DWriteWrapper_CoreText::245 // TODO:: // We need too support widthFunc semantic to be able to support NSLayout*. We could either change the API signature of this API or // create a new API to support dynamic width support. // // float width = widthFunc(widthParam, 0, 0, fontSize);

• [ ] DWriteWrapper_CoreText::264 // TODO:: // Iterate through all attributed string ranges and identify attributes so they can be used to - // - set indentation // - etc. // These can be done using the DWrite IDWriteTextFormat range property methods.

• [ ] DWriteWrapper_CoreText::434 // TODO:: find more precise value than 1.0 to increase width by to fully enclose frame

• [ ] DWriteWrapper_CoreText::487 // TODO:: // This is a temp workaround until we can have actual glyph origins

• [ ] DWriteWrapper_CoreText::555 // TODO:: find more precise value than 1.0 to increase width by to fully enclose frame

• [ ] DWriteWrapper_CoreText::53 & CTFramesetter::92 The bug number #1121 associated with the TODO does correlate to the bug, is this valid? // TODO 1121:: DWrite does not support line breaking by truncation, so just use clipping for now // TODO 1121:: DWrite does not support line breaking by truncation, so we are using clipping, so need to adjust for truncation as well

[msft-Jeyaram]

@ms-jihua @aballway Please take a look

[ms-jihua]

DWriteWrapper_CTFont.mm::473, 477 : can probably just remove the TODO: portion of the comment and leave the comment - I don't think we can ever address these.

DWriteWrapper_CoreText.mm::202 : this doesn't actually seem like a TODO, just a comment

DWriteWrapper_CoreText::53 & CTFramesetter::92: this seems like the wrong issue number...? EDIT: Looks like these should be #1342

[aballway]

DWriteWrapper_CoreText::53 & CTFramesetter::92: yea it looks like I put the wrong issue number on those, my b.

DWriteWrapper_CoreText::245: this is no longer needed and can be removed.

DWriteWrapper_CoreText::487: this depends on DWrite support but should not be necessary and can safely be removed

DWriteWrapper_CoreText::434, 555: This could be associated with a github issue if we wanted. We could still look into finding a more precise value but 1 em is indistinguishably small, and has and will continue to suffice if we don't care to invest in perfecting it.