Hygiene: fix 1687 filename case collisions & renormalize CRLF & LFS

microsoft / WinObjC

Objective-C for Windows

MIT License

6.24k stars 808 forks source link

Hygiene: fix 1687 filename case collisions & renormalize CRLF & LFS #2873

Closed DHowett-MSFT closed 6 years ago

DHowett-MSFT commented 6 years ago

This is the result of checking out on a case-sensitive filesystem and resolving all conflicts in case, then running git add --renormalize .. Binary files under deps/3rdparty have been reverted.

This change is

DHowett-MSFT commented 6 years ago

It'll be easier to review this in whitespace-agnostic mode, here.

MSFTFox commented 6 years ago

I'm a bit confused. Why are the reference images being moved (read renamed) to the actual data folder? Isn't this where the test's generated images go?

DHowett-MSFT commented 6 years ago

Good eye.

DHowett-MSFT commented 6 years ago

I've run the diff list through uniq -ic (which spits out a list of each line in a file prefixed by how many times it appears) and verified that each filename appears identical (case-insensitive) exactly twice -- that is to say, no files have moved to different folders this time.