search

microsoft / WinUI-Gallery

This app demonstrates the controls available in WinUI and the Fluent Design System.
MIT License
2.65k stars 612 forks source link

Request: move CopyButton lower #1533

Open Jay-o-Way opened 1 month ago

Jay-o-Way commented 1 month ago

Issue type

enhancement

Which version of the app?

WinUI 3 Gallery

Description

Currently, the CopyButton is usually displayed on one line, next to the related value. However, for the colors, it's displayed in the top-right corner, while the value is on the bottom. It would be nice if the CopyButton sticks immediately to the right of the value everywhere.

Screenshots

image

Windows version

Windows 11 23H2 (22631)

Additional context

Check validity / status for this message. image

Jay-o-Way commented 1 month ago

I can create a PR for this 💪 image

niels9001 commented 1 month ago

Understand the reasoning! But we moved it to the top because the brush names tend to be much longer than the titles. As a result, brush names are either clipped or wrapped, both not great.

karkarl commented 1 month ago

Is there a reason why the copy buttons don't only show up on hover? That might solve the issue with longer brush names. I remember reading a Microsoft design guideline that discourages it.

niels9001 commented 1 month ago

Is there a reason why the copy buttons don't only show up on hover? That might solve the issue with longer brush names. I remember reading a Microsoft design guideline that discourages it.

That would require adding keyboarding support as well :(

Jay-o-Way commented 1 month ago

we moved it to the top because the brush names tend to be much longer than the titles. As a result, brush names are either clipped or wrapped, both not great.

That argument is not valid in every case: image