Use Selectorbar for Sample Code

microsoft / WinUI-Gallery

This app demonstrates the controls available in WinUI and the Fluent Design System.

MIT License

2.65k stars 612 forks source link

Use Selectorbar for Sample Code #1540

Closed ghost1372 closed 2 weeks ago

ghost1372 commented 1 month ago

related to #1535

Full Code (Xaml/C#)

00002

Single Code (Xaml Only)

00001

Description

Motivation and Context

How Has This Been Tested?

Tested on my Laptop

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Jay-o-Way commented 1 month ago

Does this solve #704?

ghost1372 commented 1 month ago

Does this solve #704?

No. we need to disable horizontal scroll

ghost1372 commented 1 month ago

Thank you for creating this PR!

I think porting the SwitchPresenter control over just for this is a bit overkill, this problem can also be solved with a bit of code-behind. Also, given that people also use this app's source code for reference, introducing a new control just for this doesn't seem like the best idea.

I saw that the gallery uses some communitytoolkit Nuget packages. For a simple control, I did not use the community Nuget package, which has a larger size... That's why I copied their codes.

marcelwgn commented 1 month ago

We are in fact using Community Toolkit packages, that is correct. I would argue though, in this case, porting a complete control for something one could do with a few lines of code behind is overkill.

ghost1372 commented 1 month ago

We are in fact using Community Toolkit packages, that is correct. I would argue though, in this case, porting a complete control for something one could do with a few lines of code behind is overkill.

ok, what do you suggest? Changing visibility? Frame?

marcelwgn commented 1 month ago

ok, what do you suggest? Changing visibility? Frame?

I would probably use a ContentPresenter and have that switch the content

ghost1372 commented 1 month ago

@marcelwgn I saw your last message late, I sent 2 commits, First by changing the visibility and lastly the suggestion you gave.

Jay-o-Way commented 1 month ago

For some reason - for some controls, the content is empty.

ghost1372 commented 1 month ago

@Jay-o-Way i reverted last commit (ContentPresenter) now everything is working fine

Jay-o-Way commented 1 month ago

Does this solve #704?

No. we need to disable horizontal scroll

For me, this pr currently actually does disable horizontal movement when using the scroll wheel hovering this area. 🥳 @karkarl

karkarl commented 1 month ago

Does this solve #704?

No. we need to disable horizontal scroll

For me, this pr currently actually does disable horizontal movement when using the scroll wheel hovering this area. 🥳 @karkarl

I'm ok disabling horizontal scroll. It annoys me a lot too :P

Jay-o-Way commented 1 month ago

Question: I see muxc:Expander is used, but do we still need the muxc part? One more detail please? Removing this margin/padding would be pretty.

ghost1372 commented 1 month ago

Does this solve #704?

No. we need to disable horizontal scroll

For me, this pr currently actually does disable horizontal movement when using the scroll wheel hovering this area. 🥳 @karkarl

I'm ok disabling horizontal scroll. It annoys me a lot too :P

done

ghost1372 commented 1 month ago

Hold on, I see a little misunderstanding here. The issue in 704 was: When scrolling (vertically) across a page, coming over a code example gives an unwanted horizontal scrolling. This PR already solved that. The last commit makes it impossible to scroll horizontally. Please revert.

Done

ghost1372 commented 3 weeks ago

I think we'd want to horizontally align the XAML / C# SelectorBar with the XAML?

Done

karkarl commented 2 weeks ago

/azp run