search

microsoft / WinUI-Gallery

This app demonstrates the controls available in WinUI and the Fluent Design System.
MIT License
2.65k stars 612 forks source link

Add searchable tags to Icons #1544

Open AndrewKeepCoding opened 1 month ago

AndrewKeepCoding commented 1 month ago

Issue type

enhancement

Which version of the app?

WinUI 3 Gallery

Description

In the Icons page, you can search by Name and Unitcode point. It'd be easier to find icons if they had tags that represent the symbol or its meaning.

For example, the Color icon, which is a palette, could also be able to be found with [palette] or [theme].

Screenshots

No response

Windows version

No response

Additional context

No response

AndrewKeepCoding commented 1 month ago

If this is a change that could be considered as enhancement, I'd be happy to create a PR for this.

Jay-o-Way commented 1 month ago

Sounds like a fair idea. What would be your solution? Adding a "tag" field in WinUIGallery/DataModel/IconsData.json ?

AndrewKeepCoding commented 1 month ago

Yes. Something like the following. Nothing complicated.

{
  "Code": "E790",
  "Name": "Color",
  "Tags": ["Palette", "Theme"]
},

But since there are too many icons, I'm thinking on implementing the searching logic and some simple tags. The rest can be implemented/improved in the future.

karkarl commented 2 weeks ago

That's a great idea! Your contribution is very much welcomed.

AndrewKeepCoding commented 2 weeks ago

I'll create a PR when it's ready.