microsoft / WinUI-Gallery

This app demonstrates the controls available in WinUI and the Fluent Design System.
MIT License
2.81k stars 628 forks source link

Did you forget to add an app icon to the WinUI 3 Gallery main application? #1600

Open Gaoyifei1011 opened 2 months ago

Gaoyifei1011 commented 2 months ago

Which version of the app?

WinUI 3 Gallery

Description

Did you forget to add an app icon to the WinUI 3 Gallery main application?

Screenshots

{A7295769-EAFD-4DFF-BF89-AA699168FE38}

Windows version

Windows 11 24H2 (26052)

Additional context

None

MGGSK commented 2 months ago

The .exe file doesn't need an icon. (by default) WinUI apps use the package icon for the app and not the exe icon. Most apps don't have an exe icon. Edit: The .exe file can't even be launched directly so an exe icon is useless.

Gaoyifei1011 commented 2 months ago

The .exe file doesn't need an icon. (by default) WinUI apps use the package icon for the app and not the exe icon. Most apps don't have an exe icon. Edit: The .exe file can't even be launched directly so an exe icon is useless.

But I don't think so. First, Winui 3 is a desktop application, and UWP is a packaged application. In the task Manager, the Winui 3 desktop program shows the icon of the application instead of the packaged application icon, which does not quickly locate the application by the icon in the Task Manager. Second, Microsoft's other official packaging applications, Dev home, drawing and other software, they have set up application ICONS, so I think Winui 3 gallery should add application ICONS 然而我却不是这样认为。首先,Winui 3 是一个桌面程序,UWP 是一个打包后的应用。在任务管理器中,Winui 3 桌面程序显示的是应用程序的图标,而不是打包应用程序的图标,这并不能在任务管理器中通过图标快速定位应用程序。其次,微软官方的其他打包应用,Dev home,画图等等其他软件,他们都设置了应用程序图标,所以我认为应该给 Winui 3 gallery 添加上应用程序图标 {92920F28-79A1-421F-AE98-5DFB73BE5CC2}

MGGSK commented 2 months ago

The .exe file doesn't need an icon. (by default) WinUI apps use the package icon for the app and not the exe icon. Most apps don't have an exe icon. Edit: The .exe file can't even be launched directly so an exe icon is useless.

But I don't think so. First, Winui 3 is a desktop application, and UWP is a packaged application. In the task Manager, the Winui 3 desktop program shows the icon of the application instead of the packaged application icon, which does not quickly locate the application by the icon in the Task Manager. Second, Microsoft's other official packaging applications, Dev home, drawing and other software, they have set up application ICONS, so I think Winui 3 gallery should add application ICONS 然而我却不是这样认为。首先,Winui 3 是一个桌面程序,UWP 是一个打包后的应用。在任务管理器中,Winui 3 桌面程序显示的是应用程序的图标,而不是打包应用程序的图标,这并不能在任务管理器中通过图标快速定位应用程序。其次,微软官方的其他打包应用,Dev home,画图等等其他软件,他们都设置了应用程序图标,所以我认为应该给 Winui 3 gallery 添加上应用程序图标 {92920F28-79A1-421F-AE98-5DFB73BE5CC2}

First: WinUI 3 apps are also packaged Second: What I meant by "useless" was applying it as the app exe file icon but it is useful in the taskbar because WinUI is weird (with packaged taskbar icons). Third: I think it would be good if an exe icon was added because using an png file as a icon in the taskbar doesn't look good (no transparency). Edit: using the default exe icon look extremely wrong. Edit 2: The taskbar icon was already fixed but I still made a pr that changes the exe icon.

HEIC-to-JPEG-Dev commented 1 week ago

The icon should be added - Windows taskbar needs it to display properly Image

MGGSK commented 1 week ago

The icon should be added - Windows taskbar needs it to display properly Image

I already added the icon but they didn't close this issue. https://github.com/microsoft/WinUI-Gallery/pull/1604

HEIC-to-JPEG-Dev commented 1 week ago

The icon should be added - Windows taskbar needs it to display properly Image

I already added the icon but they didn't close this issue. #1604

It's not in the current release either

MGGSK commented 1 week ago

The icon should be added - Windows taskbar needs it to display properly Image

I already added the icon but they didn't close this issue. #1604

It's not in the current release either

It will be in the next update.