search

microsoft / WinUI-Gallery

This app demonstrates the controls available in WinUI and the Fluent Design System.
MIT License
2.84k stars 637 forks source link

Titlebar chrome buttons wrong color "invisible" #1605

Open HEIC-to-JPEG-Dev opened 3 months ago

HEIC-to-JPEG-Dev commented 3 months ago

Which version of the app?

WinUI 3 Gallery

Description

The titlebar chrome buttons (minimize, maximize, close) are not visible. Screenshot below.

I think this is because the Windows 11 setting "Show accent colour on title bars and window borders" is checked. Turning this off solves the issue - but I (and I assume lots of people) have it switched on.

Screenshots

image

Windows version

Windows 11 23H2 (22631)

Additional context

As a developer I know this issue and it has to be manually managed in code as the AppWindow theme system is broken. Using th enew Titlebar control in SDK 1.6 fixes the issue.

karkarl commented 3 months ago

I am unable to repro, can you provide more detailed repro steps?

I wonder if it's from WinUI-Gallery setting AppWindow TitleBar's caption button colours as a workaround here: https://github.com/microsoft/WinUI-Gallery/blob/cb323e1a5dff53e482ce577b48ca311cfe8d00cd/WinUIGallery/Helper/TitleBarHelper.cs#L27

HEIC-to-JPEG-Dev commented 3 months ago

If you close the app, and then set this in Windows Settings, on Windows 11, you should be able to reproduce the issue image

Jay-o-Way commented 2 months ago

Ideally, a window shouldn't have to mess with code like this and the solution is to be as "native" as possible.

it has to be manually managed in code as the AppWindow theme system is broken

Seen this so many times for so long, I wonder if Microsoft will ever fix it...

Using th enew Titlebar control in SDK 1.6 fixes the issue.

🥳

HEIC-to-JPEG-Dev commented 2 months ago

The titlebar control is not in 1.6, it was pulled :(

Jay-o-Way commented 2 months ago

The titlebar control is not in 1.6, it was pulled :(

OMG! What's the source for this info?

HEIC-to-JPEG-Dev commented 2 months ago

They announced it on the developer call. No ETA. Had to pull it from my app and revert back to older code

karkarl commented 2 months ago

The titlebar control is not in 1.6, it was pulled :(

OMG! What's the source for this info?

I can answer this question - it is true that Titlebar will not be shipping in 1.6, however, we are still committed to shipping the control eventually. It's looks "pulled" since experimental APIs cannot be shipped with a stable release.

Hopefully I can provide more info to this in a couple of weeks :)

HEIC-to-JPEG-Dev commented 1 month ago

Are we saying this won't be fixed until SDK 1.7 ?