microsoft / WinUI-Gallery

This app demonstrates the controls available in WinUI and the Fluent Design System.
MIT License
2.75k stars 619 forks source link

Narrator remains silent after activating Custom XamlUICommand app bar button in XamlUICommand. #169

Open YuliKl opened 5 years ago

YuliKl commented 5 years ago

Describe the bug

Pre-requisite: Turn on Narrator (Keyboard Shortcut: Ctrl+Win+Enter). Set Narrator to item mode.

Steps to reproduce the bug

Steps to reproduce the behavior: 1.Launch the XAML Controls Gallery Application.

  1. Activate XamlUICommand from All Controls Page.
  2. Navigate to "Custom XamlUICommand" app bar button and activate it and observe narrator reading.

Expected behavior

After activating the "Custom XamlUICommand" narrator should give the information.

Actual behavior

Narrator remains silent without reading anything.

Screenshots

image

Version Info

Gallery version (found on Settings page):

Version Info: 1.2.6.0

Windows 10 version:

Device form factor:

Additional context

Copied from internal bug

marcelwgn commented 5 years ago

I agree that this is not a behavior that we should leave in the app, however what should the narrator read out? And more importantly, how should the narrator read it? Should the focus change to an item with text?

Also: The Button examples behave the same, meaning activating them does not provide a feedback via the narrator. This should be addressed too.