microsoft / Windows-driver-samples

This repo contains driver samples prepared for use with Microsoft Visual Studio and the Windows Driver Kit (WDK). It contains both Universal Windows Driver and desktop-only driver samples.
Microsoft Public License
6.92k stars 4.93k forks source link

ACPI WMI GUID reuse #1004

Open Wer-Wolf opened 1 year ago

Wer-Wolf commented 1 year ago

It seems some vendors (ASUS, Positivio, ...) like to reuse the WMI class GUIDs from the ACPI WMI driver sample. For example, the GUID ABBC0F72-8EA1-11d1-00A0-C90629100000 is used inside the driver sample AND by ASUS:

[WMI, Dynamic, Provider("WmiProv"), guid("{ABBC0F72-8EA1-11d1-00A0-C90629100000}")] class ASWMIEvent : WmiEvent { [key, read] string InstanceName; [read] boolean Active; [WmiDataId(1)] uint32 EventID; };

Since GUIDs should be unique, maybe it would be helpful to warn OEMs to not reuse WMI GUIDs.