search

microsoft / Windows-driver-samples

This repo contains driver samples prepared for use with Microsoft Visual Studio and the Windows Driver Kit (WDK). It contains both Universal Windows Driver and desktop-only driver samples.
Microsoft Public License
6.92k stars 4.93k forks source link

Remove .exe from the INF file #1040

Closed zlockard closed 12 months ago

cgallred commented 1 year ago

@jasonknichel how can I look at the changes? GitHub thinks these .inf files are binary, I think because they are UTF16, so it won't show me the diffs.

jasonknichel commented 1 year ago

@jasonknichel how can I look at the changes? GitHub thinks these .inf files are binary, I think because they are UTF16, so it won't show me the diffs.

@cgallred - yea, git and github don't like UTF-16 files and considers them binary. :( It only does a proper text diff for ASCII and UTF-8. I diff INF files (which PNP requires to be ASCII or UTF-16 LE, with UTF-16 LE preferred since it allows proper localization) by doing the diff locally in my local clone of the sample repo. For this change, I saw that the commit ID was b0dad9afddee741cbb5422fa8bacdc6a545f4576 so in my local clone, I did this to view the changes:

git difftool -d b0dad9afddee741cbb5422fa8bacdc6a545f4576~1 b0dad9afddee741cbb5422fa8bacdc6a545f4576
zlockard commented 12 months ago

For some context here - VS/WDK doesn't have support for integrating binaries from two projects into an INF file and building the INF inline. The last PR and this one separated the exe from the INF so that the driver itself would build cleanly