search

microsoft / Windows-driver-samples

This repo contains driver samples prepared for use with Microsoft Visual Studio and the Windows Driver Kit (WDK). It contains both Universal Windows Driver and desktop-only driver samples.
Microsoft Public License
6.79k stars 4.89k forks source link

simbatt: Clear BATTERY_CAPACITY_RELATIVE field for per-battery charge display #1063

Open forderud opened 7 months ago

forderud commented 7 months ago

Clear BATTERY_INFORMATION::BATTERY_CAPACITY_RELATIVE field to enable per-battery charge display in Windows Settings when simulating multi-battery setups.

Motivating example

Example of simulated multi-battery setup prior to this PR: image As you can see, the individual batteries report 0% despite being fully charged. The aggregated 100% charge is however correct.

Corresponding example after clearing the BATTERY_CAPACITY_RELATIVE field: image As you can see, the individual batteries now correctly report 100%.

Testing instructions

Steps:

forderud commented 2 months ago

Gentle reminder.

forderud commented 2 months ago

@JakobL-MSFT Would it be possible to get some kind of explanation for why this PR was closed instead of being considered for merging?

JakobL-MSFT commented 2 months ago

I closed this PR unintentionally. I apologize. I am reopening the PR.