search

microsoft / Windows-driver-samples

This repo contains driver samples prepared for use with Microsoft Visual Studio and the Windows Driver Kit (WDK). It contains both Universal Windows Driver and desktop-only driver samples.
Microsoft Public License
6.76k stars 4.89k forks source link

Update Code-Scanning.yml jobs to use Node.js 20 #1134

Closed jacob-ronstadt closed 4 months ago

jacob-ronstadt commented 4 months ago

actions/checkout to v4 and microsoft/setup-msbuild to v2

JakobL-MSFT commented 4 months ago

I may be creating more work here, but we should make sure CodeQL workflow is aligned as close as reasonably possible with https://github.com/microsoft/Windows-driver-samples/blob/main/.github/workflows/ci.yml and https://github.com/microsoft/Windows-driver-samples/blob/main/.github/workflows/ci-pr.yml . Those two workflows uses actions that you are updating, so we should also update them for those two files. Jacob you could take a stab at this and coordinate with @NeoAdonis .

In hindsight I see similar issue here: https://github.com/microsoft/Windows-driver-samples/actions/runs/8133471231 and here: https://github.com/microsoft/Windows-driver-samples/actions/runs/8133038769 .

NeoAdonis commented 4 months ago

I agree with this observation Jakob made. Thanks for the heads-up!

@jacob-ronstadt : Because you have a PR already, could you implement the same change in both ci.yml and ci-pr.yml, please? I could create a separate PR if you prefer that instead.

jacob-ronstadt commented 4 months ago

@NeoAdonis @JakobL-MSFT Updated!