search

microsoft / Windows-driver-samples

This repo contains driver samples prepared for use with Microsoft Visual Studio and the Windows Driver Kit (WDK). It contains both Universal Windows Driver and desktop-only driver samples.
Microsoft Public License
7k stars 4.94k forks source link

Small fixes to sample. #1220

Closed judzmura closed 2 months ago

judzmura commented 2 months ago

Got some suggestions for fixes/changes to the sample from an external partner, this PR takes some of these small fixes and removes some dead code.

NeoAdonis commented 2 months ago

In general, changes should target the develop branch rather than the main branch. However, we just merged develop into main and we are expecting some more changes before doing an additional merge, so I'll complete this PR.

vrjtikonen commented 2 months ago

Hi @judzmura Thank your taking in these fixes. However I think you forgot the commit (https://github.com/microsoft/Windows-driver-samples/pull/1215/commits/bab2233e85d57a73b355d28d1365dbf5cfbee4ca) from the original pull request. Commit adds missing stuff on the inf file that is referenced by the sample code (most importantly configuration registry keys). Also fixes to kshelper and savedata are missing.