search

microsoft / WindowsAppSDK

The Windows App SDK empowers all Windows desktop apps with modern Windows UI, APIs, and platform features, including back-compat support, shipped via NuGet.
https://docs.microsoft.com/windows/apps/windows-app-sdk/
MIT License
3.84k stars 320 forks source link

MakePri verbose log isn't really verbose #1820

Open dotMorten opened 2 years ago

dotMorten commented 2 years ago

Describe the bug

I'm hitting a build error in MakePri, telling me "ERROR: PRI175: 0x80073b0f - Processing Resources failed with error: Duplicate Entry.". This is with the /Verbose flag on, but there is no indication which files are duplicate. so it's near-impossible to find the bug.

Steps to reproduce the bug

I don't have a share-able repro at this point, since the error message can't help me pinpoint the issue so I can create a simple repro. But the repro would consist of triggering the above error.. However here's the output from the build command:

>C:\Users\mn\.nuget\packages\microsoft.windows.sdk.buildtools\10.0.22000.194\bin\10.0.22000.0\x64\makepri.exe New -ProjectRoot e:\GitHub\Esri\arcgis-runtime-samples-dotnet\src\WinUI\ArcGISRuntime.WinUI.Viewer\ -ConfigXml obj\x64\Debug\net6.0-windows10.0.19041.0\win10-x64\priconfig.xml -OutputFile e:\GitHub\Esri\arcgis-runtime-samples-dotnet\output\WinUI\Debug\x64\net6.0-windows10.0.19041.0\win10-x64\resources.pri -IndexName f7c5cd81-9a29-42b8-9563-0700a9d08108 -Verbose -Overwrite
Option Verbose specified
Option Overwrite specified
Index Pass Completed: obj\x64\Debug\net6.0-windows10.0.19041.0\win10-x64\filtered.layout.resfiles
AlternateForm Qualifiers: UNPLATED
Scale Qualifiers: 200,400,150,125,100
TargetSize Qualifiers: 256,16,24,32,48

Index Pass Completed: obj\x64\Debug\net6.0-windows10.0.19041.0\win10-x64\resources.resfiles

Index Pass Completed: obj\x64\Debug\net6.0-windows10.0.19041.0\win10-x64\pri.resfiles
Language Qualifiers: EN-US

Index Pass Completed: embed.resfiles

ERROR: PRI175: 0x80073b0f - Processing Resources failed with error: Duplicate Entry.

ERROR: PRI222: 0x80073b0f - Unspecified error occurred.

Expected behavior

A list of files being used for input, and specifically in the error which files are duplicate.

Screenshots

No response

NuGet package version

1.0.0

Packaging type

Packaged (MSIX)

Windows version

Windows 11 (22000)

IDE

Visual Studio 2022

Additional context

No response

andrewleader commented 2 years ago

@axelandrejs MakePri is your area (resources/MRT), yeah?

huichen123 commented 2 years ago

I think we have fixed for this particular error, and we will print the resource name for this error. However the fix won't be available until next Windows SDK (not Windows App SDK).

dotMorten commented 2 years ago

@huichen123 Any ideas how to find the problem until the new SDK hits?

huichen123 commented 2 years ago

@dotMorten Try replace makepri.exe with the one from RS5 (or 19H1) SDK.

dotMorten commented 2 years ago

Found the problem, so here's a repro. Just unzip and build this: ArcGISRuntime.WinUI.Viewer.zip

The build error can be fixed by deleting Assets\Square44x44Logo.targetsize-24_altform-unplated.png.

I'd like for the build error to help me realize this file is the problem (and why).

shelllet commented 2 years ago 
1>WINAPPSDKGENERATEPROJECTPRIFILE : error : PRI175: 0x80073b0f - Processing Resources failed with error: Duplicate Entry.
1>WINAPPSDKGENERATEPROJECTPRIFILE : error : PRI222: 0x80073b0f - Unspecified error occurred.
anpin commented 2 years ago

This is still happening to me on following setup for net6.0-windows10.0.17763.0 workload of MAUI app with Microsoft.WindowsAppSDK 1.1.0

binlog

OS

Edition Windows 10 Pro N
Version 21H2
Installed on    ‎9/‎21/‎2021
OS build    19044.1706
Experience  Windows Feature Experience Pack 120.2212.4170.0

VS

Microsoft Visual Studio Community 2022 (3)
Version 17.3.0 Preview 1.1
VisualStudio.17.Preview/17.3.0-pre.1.1+32519.111
Microsoft .NET Framework
Version 4.8.04084

Installed Version: Community

Visual C++ 2022   00482-10000-00261-AA133
Microsoft Visual C++ 2022

.NET Core Debugging with WSL   1.0
.NET Core Debugging with WSL

ADL Tools Service Provider   1.0
This package contains services used by Data Lake tools

ASA Service Provider   1.0

ASP.NET and Web Tools 2019   17.3.122.33185
ASP.NET and Web Tools 2019

AvaloniaPackage Extension   1.0
AvaloniaPackage Visual Studio Extension Detailed Info

Azure App Service Tools v3.0.0   17.3.122.33185
Azure App Service Tools v3.0.0

Azure Data Lake Tools for Visual Studio   2.6.5000.0
Microsoft Azure Data Lake Tools for Visual Studio

Azure Functions and Web Jobs Tools   17.3.122.33185
Azure Functions and Web Jobs Tools

Azure Stream Analytics Tools for Visual Studio   2.6.5000.0
Microsoft Azure Stream Analytics Tools for Visual Studio

C# Tools   4.3.0-1.22254.1+9919d7e7bd753404a5d2328e5e3fb2de635169f3
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Extensibility Message Bus   1.2.6 (master@34d6af2)
Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.

IncrediBuild Build Acceleration   1.6.0.2
IncrediBuild effectively reduces compilation and development times by up to 90%.

Microsoft Azure Hive Query Language Service   2.6.5000.0
Language service for Hive query

Microsoft Azure Stream Analytics Language Service   2.6.5000.0
Language service for Azure Stream Analytics

Microsoft Azure Tools for Visual Studio   2.9
Support for Azure Cloud Services projects

Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Mono Debugging for Visual Studio   17.3.11 (4f73250)
Support for debugging Mono processes with Visual Studio.

NuGet Package Manager   6.3.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

Project System Tools   1.0
Tools for working with C#, VisualBasic, and F# projects.

Razor (ASP.NET Core)   17.0.0.2222701+751db1ebea5e6a9ecc7fa57fe447180422afa610
Provides languages services for ASP.NET Core Razor.

SQL Server Data Tools   17.0.62204.01010
Microsoft SQL Server Data Tools

Syntax Visualizer   1.0
An extension for visualizing Roslyn SyntaxTrees.

ToolWindowHostedEditor   1.0
Hosting json editor into a tool window

TypeScript Tools   17.0.10420.2001
TypeScript Tools for Microsoft Visual Studio

UnoPlatformPackage Extension   1.0
UnoPlatformPackage Visual Studio Extension Detailed Info

Visual Basic Tools   4.3.0-1.22254.1+9919d7e7bd753404a5d2328e5e3fb2de635169f3
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools   17.1.0-beta.22178.3+6da0245a7ce4bb8483b8d1f2993c8ecaea967ad9
Microsoft Visual F# Tools

Visual Studio IntelliCode   2.2
AI-assisted development for Visual Studio.

VisualStudio.DeviceLog   1.0
Information about my package

VisualStudio.Mac   1.0
Mac Extension for Visual Studio

VSPackage Extension   1.0
VSPackage Visual Studio Extension Detailed Info

Xamarin   17.3.0.151 (d17-3-p1.1@5a59bfa)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin Designer   17.3.0.33 (remotes/origin/d17-3-1@9c0d11a29)
Visual Studio extension to enable Xamarin Designer tools in Visual Studio.

Xamarin.Android SDK   12.3.99.58 (main/64b22fc)
Xamarin.Android Reference Assemblies and MSBuild support.
    Mono: adf1bc4
    Java.Interop: xamarin/java.interop/release/6.0.3xx@2a882d2d
    ProGuard: Guardsquare/proguard/v7.0.1@912d149
    SQLite: xamarin/sqlite/3.38.2@7b1e016
    Xamarin.Android Tools: xamarin/xamarin-android-tools/main@fc3c2ac
anpin commented 2 years ago

Building the project targeting net6.0-windows10.0.25131.0 with <UseWindowsSdkPreview>true</UseWindowsSdkPreview> producing more verbose log, but still doesn't mention source of the issue. binlog I also tried to create new project and it builds fine with this nuget, so it must be something inside the project itself, however none of the resources were changed and it was building fine with previous version which I think was 1.0.3 @huichen123 @andrewleader any other advice you can give on how to pinpoint the source of the issue?

huichen123 commented 2 years ago

@anpin you may install Windows 10 SDK, version 1809 (10.0.17763.0) at https://developer.microsoft.com/en-us/windows/downloads/sdk-archive, find makepri.exe there, and replace the makepri.exe the build uses with that one temporarily.

anpin commented 2 years ago

@huichen123 that fixed it altogether and the app builds and starts, thanks! Although it crashes right away with #2443

huichen123 commented 2 years ago

@anpin it's strange that makes a functional difference. If you can share the repro project, I'd be interested in taking a look. Thanks.

anpin commented 2 years ago

@anpin it's strange that makes a functional difference. If you can share the repro project, I'd be interested in taking a look. Thanks.

you can try this branch project samples\APES.UI.MAUI.Sample

However I tried to put back original makepri.exe, removed bin and obj, restarted VS, rebuilt and the error is gone. I have no idea what is going on here.