search

microsoft / WindowsAppSDK

The Windows App SDK empowers all Windows desktop apps with modern Windows UI, APIs, and platform features, including back-compat support, shipped via NuGet.
https://docs.microsoft.com/windows/apps/windows-app-sdk/
MIT License
3.85k stars 326 forks source link

Stray IntelliSense metadata bundled with WindowsAppSDK-1.0.0 #1861

Open riverar opened 2 years ago

riverar commented 2 years ago

Microsoft.Windows.System.xml https://github.com/microsoft/WindowsAppSDK/blob/99ac9397a535b72bcc763869bf11e7cf4e103390/build/AzurePipelinesTemplates/WindowsAppSDK-CreateNugetPackage-Job.yml#L78

Microsoft.Windows.PushNotifications.xml https://github.com/microsoft/WindowsAppSDK/blob/99ac9397a535b72bcc763869bf11e7cf4e103390/build/AzurePipelinesTemplates/WindowsAppSDK-CreateNugetPackage-Job.yml#L80

andrewleader commented 2 years ago

I think this is sort of related to #1775 however it sounds slightly different (this seems like some other Experimental files that we need to not include on Stable right now).

@riverar I'm only seeing these XML IntelliSense files under the uap folders, do these files have any impact (like maybe on Rust bindings), or this is just a "clean up and don't include things that aren't used" sort of feedback?

@BenJKuhn looks like this is another experimental file that slipped into the stable NuGet package.

riverar commented 2 years ago

No impact just something I noticed when working with the metadata. Thanks!

BenJKuhn commented 2 years ago

@riverar Thanks for catching this. Right now we don't have infrastructure in place to reprocess experimental APIs out of the IntelliSense data. This seems like a good one to put on @DefaultRyan's backlog.