microsoft / WindowsAppSDK

The Windows App SDK empowers all Windows desktop apps with modern Windows UI, APIs, and platform features, including back-compat support, shipped via NuGet.
https://docs.microsoft.com/windows/apps/windows-app-sdk/
MIT License
3.72k stars 308 forks source link

Fix initialization of _InOut_ variable #4397

Closed bpulliam closed 1 month ago

bpulliam commented 1 month ago

A recent prefast bug fix initialized an Out variable athat was actually an InOut, so that the initialization clobbered the existing value. The parameter was not being used as an out param, so the correct fix is to change it to a const.

bpulliam commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).
Scottj1s commented 1 month ago

actually a pure in param, so a const & could be used

bpulliam commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago
Azure Pipelines successfully started running 1 pipeline(s).