search

microsoft / WindowsAppSDK

The Windows App SDK empowers all Windows desktop apps with modern Windows UI, APIs, and platform features, including back-compat support, shipped via NuGet.
https://docs.microsoft.com/windows/apps/windows-app-sdk/
MIT License
3.8k stars 320 forks source link

Fix missing trimming annotation and set couple cswinrt properties #4451

Closed manodasanW closed 4 months ago

manodasanW commented 4 months ago

We have IsTrimmable set in our projection projects. But this doesn't show up in the resulting assembly as an assembly attribute. This turns out it is due to at some point we started using a custom AssemblyInfo.cs which meant the attribute that was generated in the default one is no longer there. While checking the assembly I also noticed the IIDOptimizer is inserting a type that is unused given nothing needs to be optimized and that the vtable lookup generation table was generated because CsWinRT failed to properly detect this as a projection project. So, disabling those with the respective properties to control them.

A microsoft employee must use /azp run to validate using the pipelines below.

WARNING: Comments made by azure-pipelines bot maybe inaccurate. Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR (https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary) and run the build against your PR branch with the default parameters.

manodasanW commented 4 months ago

/azp run

azure-pipelines[bot] commented 4 months ago
Azure Pipelines successfully started running 1 pipeline(s).