microsoft / WindowsAppSDK

The Windows App SDK empowers all Windows desktop apps with modern Windows UI, APIs, and platform features, including back-compat support, shipped via NuGet.
https://docs.microsoft.com/windows/apps/windows-app-sdk/
MIT License
3.84k stars 320 forks source link

Partner Center reporting a bug for latest version of BuildTools #4480

Open DRAirey1 opened 5 months ago

DRAirey1 commented 5 months ago

Describe the bug

I have an application that builds, runs and passes all validation tests locally, but when I submit it to the store, I get:

Package acceptance validation error: The package Desktop (Package)_1.35.14.0_x86_Production.msix uses an unsupported version of file makepri.exe (10.0.26100.1). The following versions are allowed: < 10.0.10500.0; >= 10.0.10586.0 & < 10.0.11000.0; >= 10.0.14383.0 & < 10.0.14800.0; >= 10.0.15053.0 & < 10.0.15100.0; >= 10.0.16299.0 & < 10.0.16350.0; >= 10.0.17134.0 & < 10.0.17500.0; >= 10.0.17763.0 & < 10.0.18199.0; >= 10.0.18362.0 & < 10.0.18799.0; >= 10.0.19041.0 & < 10.0.19399.0; >= 10.0.20348.0 & < 10.0.21242.0; >= 10.0.22000.194 & < 10.0.22350.0; >= 10.0.22621.0 & < 10.0.25054.0. Please update your Visual Studio build tools and try again. Package acceptance validation error: The package Desktop (Package)_1.35.14.0_x64_Production.msix uses an unsupported version of file makepri.exe (10.0.26100.1). The following versions are allowed: < 10.0.10500.0; >= 10.0.10586.0 & < 10.0.11000.0; >= 10.0.14383.0 & < 10.0.14800.0; >= 10.0.15053.0 & < 10.0.15100.0; >= 10.0.16299.0 & < 10.0.16350.0; >= 10.0.17134.0 & < 10.0.17500.0; >= 10.0.17763.0 & < 10.0.18199.0; >= 10.0.18362.0 & < 10.0.18799.0; >= 10.0.19041.0 & < 10.0.19399.0; >= 10.0.20348.0 & < 10.0.21242.0; >= 10.0.22000.194 & < 10.0.22350.0; >= 10.0.22621.0 & < 10.0.25054.0. Please update your Visual Studio build tools and try again. Package acceptance validation error: The package Desktop (Package)_1.35.14.0_ARM64_Production.msix uses an unsupported version of file makepri.exe (10.0.26100.1). The following versions are allowed: < 10.0.10500.0; >= 10.0.10586.0 & < 10.0.11000.0; >= 10.0.14383.0 & < 10.0.14800.0; >= 10.0.15053.0 & < 10.0.15100.0; >= 10.0.16299.0 & < 10.0.16350.0; >= 10.0.17134.0 & < 10.0.17500.0; >= 10.0.17763.0 & < 10.0.18199.0; >= 10.0.18362.0 & < 10.0.18799.0; >= 10.0.19041.0 & < 10.0.19399.0; >= 10.0.20348.0 & < 10.0.21242.0; >= 10.0.22000.194 & < 10.0.22350.0; >= 10.0.22621.0 & < 10.0.25054.0. Please update your Visual Studio build tools and try again.

Steps to reproduce the bug

  1. Install the latest version of SDK BuildTools in your WinUI project.

  2. Update to the latest version of Visual Studio.

  3. Build your application.

  4. Submit it to the Windows Store.

Expected behavior

I expect the application to pass the validation tests.

Screenshots

image

NuGet package version

None

Packaging type

Packaged (MSIX)

Windows version

No response

IDE

Visual Studio 2022

Additional context

No response

myokeeh commented 4 months ago

Seeing this too

myokeeh commented 4 months ago

To clarify, the app I tried submitted is a UWP app. I think the Partner Center isn't ready for 10.0.26100 yet.

shyamshr93 commented 4 months ago

facing the same issue. any update on this ?

gagansuie commented 4 months ago

Same issue here as well. Reverting back to this version in the mean time.

<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.3233" />

Armorost commented 4 months ago

uninstall "Microsoft.Windows.SDK.BuildTools" from the app Packages seems to remove the pb to me

ritesh3103 commented 4 months ago

The version 10.0.26100.1 was updated on May 22, 2024 and after a month or more, Microsoft Partner Center is not ready for it. Reverting back to the version 10.0.22621.3233 solved the issue.

jbe2277 commented 3 months ago

Any updates regarding this issue?

Rarisma commented 3 months ago

I am experiencing this too.

zhuxb711 commented 3 months ago

Same here. Only way to solve this is downgrade the BuildTools.

MartinZikmund commented 3 months ago

Also just hit this problem, but have no workaround, as some of my dependencies already bumped to latest stable as well

matthewacme commented 2 months ago

Aug 14th and I'm still seeing this

IsmailHassani commented 2 months ago

Same here

Sevael commented 2 months ago

:( Same here

SolidRockProgrammer commented 1 month ago

Same here, we can't deploy our latest version UNO app, and we can't down grade.

MartinZikmund commented 1 month ago

@SolidRockProgrammer if you don't mind using older version of Uno.Extensions, you can use the following in Directory.Build.Props:

<!-- Temporary workaround for https://github.com/microsoft/WindowsAppSDK/issues/4480 -->
<WinAppSdkBuildToolsVersion Condition="$(TargetFramework.Contains('windows10'))">10.0.22621.3233</WinAppSdkBuildToolsVersion>
<UnoExtensionsVersion Condition="$(TargetFramework.Contains('windows10'))">4.2.2</UnoExtensionsVersion>

This is, of course, just a workaround, and the issue itself needs to be resolved

PIN0L33KZ commented 1 month ago

Is that really STILL a thing??

Got the following error: Package acceptance validation error: The package Packaging Project_2.2.1.0_x86.appx uses an unsupported version of file makepri.exe (10.0.26100.1). The following versions are allowed: < 10.0.10500.0; >= 10.0.10586.0 & < 10.0.11000.0; >= 10.0.14383.0 & < 10.0.14800.0; >= 10.0.15053.0 & < 10.0.15100.0; >= 10.0.16299.0 & < 10.0.16350.0; >= 10.0.17134.0 & < 10.0.17500.0; >= 10.0.17763.0 & < 10.0.18199.0; >= 10.0.18362.0 & < 10.0.18799.0; >= 10.0.19041.0 & < 10.0.19399.0; >= 10.0.20348.0 & < 10.0.21242.0; >= 10.0.22000.194 & < 10.0.22350.0; >= 10.0.22621.0 & < 10.0.25054.0. Please update your Visual Studio build tools and try again.

MartinZikmund commented 1 month ago

CC @Sergio0694 @dpaulino - do you have a point of contact for this at Partner Center team that could help please?

Sergio0694 commented 1 month ago

I'd suggest pinging ankur06 in the microsoft-store channel on Discord (https://aka.ms/microsoftstorediscord). He's the PM for Partner Center working on the submission pipeline, he might be able to help. As far as I know though this is just a matter of the pipeline not having been updated yet, so it likely just needs time. Keep in mind that 26100 isn't even out yet (the SDK is stable, but Windows 26100 isn't available yet in GA).

under3415 commented 1 month ago

myokeeh has pinged ankur06 in microsoft-store Discord channel šŸ‘

KevinLaMS commented 1 month ago

Hey, @DRAirey1 I am newly joining the team and will take a look at this? Thanks!

BrianDT commented 1 month ago

Microsoft have requested an update to one of my apps and will delist the app at the end of the September if a new version has not been published by then. This issue is a major inconvenience.

DCorrBECare commented 1 month ago

Is there any news regarding this problem?

myokeeh commented 1 month ago

@KevinLaMS, slightly off topic: I have some devices that are already on 10.0.26100 and I'm noticing a pattern that those devices are not getting automatic updates for UWP apps that I have in the Store with new updates. TargetPlatformVersion is 10.0.22621.0 and TargetPlatformMinVersion is 10.0.19041.0 for those apps. They are LOB apps.

I assumed insider builds would get apps automatically updated since they're always going to be higher than the TargetPlatformVersion. What's preventing automatic updates?

IsmailHassani commented 1 month ago

Same here The thing that worked for me is to remove the reference of the build tools. Azure Devops build seems to figure it out itself.

matthewacme commented 1 month ago

@IsmailHassani

unfortunately we are not using Azure Devops (we are using GitHub tools) so that's not an option for us

under3415 commented 1 month ago

People saying that removing "the reference to the build tools" fixed the problem, do you mean that you were able to use the old SDK to build you app, or that you managed to use the latest SDK?

I removed the SDK and built my UWP using the old SDK, would not call that a fix though.

IsmailHassani commented 1 month ago

People saying that removing "the reference to the build tools" fixed the problem, do you mean that you were able to use the old SDK to build you app, or that you managed to use the latest SDK?

I removed the SDK and built my UWP using the old SDK, would not call that a fix though.

This depends totally on which version of the buildtools is installed on de build server. Azure Devops hosted build server uses an older version hence the error. If you have your own build server, there is probably an older version installed. Either update this one or downgrade the sdk buildtools to the same version. I'm using Azure Devops and noticed, that i didn't need the strong refrence in my csproj file (WinUI). Last week finished updates and publication of 5 apps to the Microsoft store.

Frankly i don't know why i would need this reference in my project if the build server already has this sdk. ;)

A thing to consider is of course the fact that some people mention UWP which has a different project structure and afaik only buildable with msbuild. WinUI can be build with dotnet publish.

under3415 commented 1 month ago

I've tried the new SDK which is now available, version is 10.0.21600.1742

Still the same issue:

Package acceptance validation error: The package uses an unsupported version of file MakePri.exe (10.0.26100.1742). The following versions are allowed: < 10.0.10500.0; >= 10.0.10586.0 & < 10.0.11000.0; >= 10.0.14383.0 & < 10.0.14800.0; >= 10.0.15053.0 & < 10.0.15100.0; >= 10.0.16299.0 & < 10.0.16350.0; >= 10.0.17134.0 & < 10.0.17500.0; >= 10.0.17763.0 & < 10.0.18199.0; >= 10.0.18362.0 & < 10.0.18799.0; >= 10.0.19041.0 & < 10.0.19399.0; >= 10.0.20348.0 & < 10.0.21242.0; >= 10.0.22000.194 & < 10.0.22350.0; >= 10.0.22621.0 & < 10.0.25054.0. Please update your Visual Studio build tools and try again.
Package acceptance validation error: The package uses an unsupported version of file MakePri.exe (10.0.26100.1742). The following versions are allowed: < 10.0.10500.0; >= 10.0.10586.0 & < 10.0.11000.0; >= 10.0.14383.0 & < 10.0.14800.0; >= 10.0.15053.0 & < 10.0.15100.0; >= 10.0.16299.0 & < 10.0.16350.0; >= 10.0.17134.0 & < 10.0.17500.0; >= 10.0.17763.0 & < 10.0.18199.0; >= 10.0.18362.0 & < 10.0.18799.0; >= 10.0.19041.0 & < 10.0.19399.0; >= 10.0.20348.0 & < 10.0.21242.0; >= 10.0.22000.194 & < 10.0.22350.0; >= 10.0.22621.0 & < 10.0.25054.0. Please update your Visual Studio build tools and try again.
Package acceptance validation error: The package uses an unsupported version of file MakePri.exe (10.0.26100.1742). The following versions are allowed: < 10.0.10500.0; >= 10.0.10586.0 & < 10.0.11000.0; >= 10.0.14383.0 & < 10.0.14800.0; >= 10.0.15053.0 & < 10.0.15100.0; >= 10.0.16299.0 & < 10.0.16350.0; >= 10.0.17134.0 & < 10.0.17500.0; >= 10.0.17763.0 & < 10.0.18199.0; >= 10.0.18362.0 & < 10.0.18799.0; >= 10.0.19041.0 & < 10.0.19399.0; >= 10.0.20348.0 & < 10.0.21242.0; >= 10.0.22000.194 & < 10.0.22350.0; >= 10.0.22621.0 & < 10.0.25054.0. Please update your Visual Studio build tools and try again.

I bet you that someone just needs to add this to the store validation config >=10.0.26100.1 & < 10.0.27000.0;

marwalsch commented 1 month ago

Has someone already tried contacting Partner Center support about this? I feel like this might be nothing than a configuration issue on their end like @under3415 suggested.

This being an ongoing issue for almost 4 months with barely any feedback is becoming a bit of a nuisance.

DRAirey1 commented 1 month ago

I think I finally fixed this. I got rid of all the package references to Microsoft.WindowsAppSDK and Microsoft.Windows.SDK.BuildTools in all my .csproj files. That is, I deleted this line wherever I found it:

<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.3233" />

IMPORTANT NOTE: You need to do this to all the packages you consume as well. I had a package of WinUI resources (controls, formatters, etc.), that was still referencing the SDK.BuildTools. It wasn't until I removed the ALL the references in every package that I imported that I was able to successfully upload to the Microsoft Partner Center with the latest version of everything.

matthewacme commented 1 month ago

@DRAirey1 Hey David,

I'm successfully submitting a WinUI app with

<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetPlatformMinVersion>10.0.19044.0</TargetPlatformMinVersion>

and

<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.5.240802000" />
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.3233" />

in all the packages.

Any upgrade from those libraries however and I get the "not supported" error.

I'm using 1.5.240802000 for the WAS and you are 1.5.240428000 for your WAS

I don't know if that is any help to you.

myokeeh commented 1 month ago

@KevinLaMS I made another attempt to submit for version 26100 thinking this would be fixed now that 24H2 is GA. No luck.

IsmailHassani commented 1 month ago

@KevinLaMS I made another attempt to submit for version 26100 thinking this would be fixed now that 24H2 is GA. No luck.

I'm wondering what the issue could be. Any chance you can share your csproj file and the pipeline yaml file?

under3415 commented 1 month ago

The issue seems quite simple. When store validates the package, it does not recognize the new SDK. Probably just needs a config update, but this is very low on Microsoft backlog.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Ismail Hassani @.> Sent: Wednesday, October 2, 2024 11:07:46 PM To: microsoft/WindowsAppSDK @.> Cc: under3415 @.>; Mention @.> Subject: Re: [microsoft/WindowsAppSDK] Partner Center reporting a bug for latest version of BuildTools (Issue #4480)

@KevinLaMShttps://github.com/KevinLaMS I made another attempt to submit for version 26100 thinking this would be fixed now that 24H2 is GA. No luck.

I'm wondering what the issue could be. Any chance you can share your csproj file and the pipeline yaml file?

ā€” Reply to this email directly, view it on GitHubhttps://github.com/microsoft/WindowsAppSDK/issues/4480#issuecomment-2388230688, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA5N3HWYVMWREBKWPMYOMPLZZPAXFAVCNFSM6AAAAABI6RUFFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBYGIZTANRYHA. You are receiving this because you were mentioned.Message ID: @.***>

myokeeh commented 1 month ago

I agree with @under3415. It's on the Partner Center side. What's frustrating is this is not the first time this happened. I don't know why the lesson hasn't been learned. Almost every time there's a new SDK version, they fumble here.

under3415 commented 1 month ago

Someone needs to tell them this is affecting AI and it will get fixed in 10 minutes :-D

frogcrush commented 1 week ago

Still an issue, can't downgrade due to Uno and even other Microsoft packages using the newer version of the SDK.

zhuxb711 commented 1 week ago

You guys still not fix this issue even 24H2 released already

applefanbois commented 1 week ago

What a shameful disgusting disgrace. Don't you have any self respect Microsoft?

Steve Balmer loved the developers and treated us like kings. Now we are treated like trash. Don't you realize that if we don't make app for Windows, you will disappear?

michalleptuch commented 4 days ago

If you don't want to downgrade the package, you can always modify the final manifest:

Image

Image

Image

under3415 commented 3 days ago

Hi, @michalleptuch I tried your MSIX Packaging Tool workaround but am getting this error:

Package acceptance validation error: APPX_E_INVALID_BLOCKMAP - The package's block map is invalid. The package must be created with a valid app packager.

This is what I tried:

  1. Installed "MSIX Packaging Tool" from Windows app store
  2. Unzipped my .msixupload file
  3. Unzipped my .msixbundle file
  4. Used "MSIX Packaging Tool" to modify manifests in 3 msix files (x86, x64 and arm64) to set makepri.exe version to 10.0.25053.0 which is acceptable to the store. I saved the msix files as new files, then replaced the existing files with modified versions.
  5. Zipped the files into a new .msixbundle file using 7zip
  6. Zipped the files into a new .msixupload file using 7zip
  7. Submitted to the store

I suspect I should not have used 7zip to create bundles in steps 5 & 6, but not sure how to use "MSIX Packaging Tool" to (re)create a bundle.

michalleptuch commented 3 days ago

Hi @under3415, unfortunately I didn't test it on msixbundle, sorry for the oversight :(