search

microsoft / WindowsCompositionSamples

The Windows Composition Samples have moved here: https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph
https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph
MIT License
1.12k stars 287 forks source link

Use Windows Community Toolkit library instead of custom code #348

Closed wldevries closed 3 months ago

wldevries commented 4 years ago

It would be helpful for new users to be pointed to the Windows Community Toolkit for extra functionality. The ExpressionBuilder is best used as a library instead of copying the code from this sample. Similarly a user is better off using a library for loading image brushes instead of the half native implementation that is hard to copy to your own solution.

Use functionality from the Windows Community Toolkit instead of the custom implementations for

Issue Type

[ ] Bug Report
[x] Feature Request
[ ] Sample request
[ ] Documentation issue or request
[ ] Other – Please describe:

UserVoice link

Current Behavior

Expected Behavior

Steps to Reproduce (for bugs)

Your Environment

hawkerm commented 3 years ago

I actually think the ExpressionBuilder code here is what's in the Toolkit. I don't know the history, but it'd certainly make sense to try and simplify the sample repo by using the Toolkit as a dependency.