Update Dependencies and Targets to build in VS 2019

microsoft / WindowsCompositionSamples

The Windows Composition Samples have moved here: https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph

https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph

MIT License

1.12k stars 287 forks source link

Update Dependencies and Targets to build in VS 2019 #350

Closed hawkerm closed 2 years ago

hawkerm commented 3 years ago

Pull Request Type

[x] Bugfix
[ ] New Sample
[ ] Other - Please describe:

Issue

Fixes #343

Proposed Changes

Update VS Tooling, UWP, and Win2D dependencies
Move Min Target to 16299 to get newer build chain (everything before then is out of mainstream support, and that least LTSC branch is beyond it.) Windows 10 Version History

Was able to build and run fine 🎉

Tried on 16.8.3 and 16.9.1

ghost commented 3 years ago

All CLA requirements met.

kevinguo305 commented 2 years ago

Hey Michael,

Thanks so much for the PR. After running the project, we were still running into a Win2D issue, so we've gone ahead and updated the Win2D version as well as the platform toolset so that it works with VS2019 which should address the build issues (Commit link here). Please let us know if you're experiencing any issues still.

Note that we'll be moving this project over to the Windows App SDK, but we'll tag this commit so that people have easier reference to the UWP version.