microsoft / WindowsCompositionSamples

The Windows Composition Samples have moved here: https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph
https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph
MIT License
1.13k stars 287 forks source link

InkCanvas and UIElement's ManipulationModeCompleted not firing #45

Closed mjracca closed 8 years ago

mjracca commented 8 years ago

I'm working with a pannable and zoomable ScrollViewer which contains multiple elements you can move around and an InkCanvas on top where you can draw.

The issue that we are having is that, when manipulating an element and touching with another hand to the canvas or other element, sometimes the manipultion events stops firing, leaving the element in a weird state, where you can't interact with it anymore. ManipulationStarted and ManipulationCompleted are never called again, and sometimes ManipulationDelta works.

Any idea? Which we found out it's that if we put the InkCanvas below all the elements, then it never breaks, but we need the InkCanvas to be on top of every element.

We submited the example here. To reproduce, try to scale the element with two fingers, as fast as you can. You will notice that at some point the element will break.

Also, you can watch a video of how we reproduced it here. We broke the Whiteboard app for Surface Hub just moving an element and touching the canvas at the same time. After doing that, then we weren't able to move the elements any more.

pgills commented 8 years ago

@mjracca Thanks for the repo and video, these are super helpful for debugging.

What builds are you seeing this behavior on?

We'll get some folks on the team to take a look.

mjracca commented 8 years ago

I'm using the production build. I will install the preview OS and SDKs soon, but this happens to us since almost 1 year now.

We could also reproduce this bug in the OneNote app, which I think is the same as the Whiteboard app after all.

likuba commented 8 years ago

Thanks for the info! I notice in the video you are showing this on a surface hub device. Are you seeing this on other devices as well (such as a laptop), or only on the surface hub?

mjracca commented 8 years ago

Yes! We are having this issue on every device. On Mon, Apr 11, 2016 at 21:34 Lindsay Kubasik notifications@github.com wrote:

Thanks for the info! I notice in the video you are showing this on a surface hub device. Are you seeing this on other devices as well (such as a laptop), or only on the surface hub?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Microsoft/WindowsUIDevLabs/issues/45#issuecomment-208640811

likuba commented 8 years ago

Hi @mjracca.

Thanks for letting us know about the issue! I went ahead and filed a product bug and the team who owns this area has investigated. Over the past year we have made some changes in this area and it sounds like the provided sample app no longer repros the issue on more recent builds. For now I'm going to close this issue, but please let us know if you are seeing issues with your sample app after upgrading your build to the next version of Windows.

mjracca commented 8 years ago

Thanks @likuba! We tested this out in the Insider build, with the Anniversary Update and it finally works correctly :) :)

If this happen again in future build I'll let you know (since it already happened to us that some updates fixes the issue, and other didn't work)