microsoft / XLIFF2-Object-Model

If you’re looking to store localization data and propagate it through your localization pipeline allowing tools to interoperate then you may want to use the XLIFF 2.0 object model. The XLIFF 2.0 object model implements the OASIS Standard for the XLIFF 2.0 specification as defined at http://docs.oasis-open.org/xliff/xliff-core/v2.0/xliff-core-v2.0.html.
Other
86 stars 25 forks source link

<mrk> and <sm> elements with type="generic" should have the "translate" attribute set explicitly #10

Closed lziman closed 8 years ago

lziman commented 8 years ago

In XLIFF 2.0 documentation is specified that if the “type” is generic then the “translate” attribute must be explicitly set.

When trying to validate files using Okapi validator (http://okapi-lynx.appspot.com/validation) it results the same thing: and elements with type=”generic” must have “translate” attribute explicitly set

Example of invalid elements which are not detected by the validator:

<mrk id="1"/> 
or 
<mrk id="1" type="generic"/>

This elements should look like this to be valid:

<mrk id="1" translate="yes"/> 
or 
<mrk id="1" type="generic" translate="yes" />

When serializing the document the "translate" type will not be set explicitly if is default. The only way to force this is by overwriting the default value with the default value.

The validator should detect this elements as invalid elements and when serializing the document, the "translate" attribute must be explicitly set on all and elements with generic type (default type).

RyanKing77 commented 8 years ago

We have reproduced the issue and are preparing a fix. Thanks.

RyanKing77 commented 8 years ago

We have released this fix. Thanks for reporting it!