search

microsoft / XamlBehaviors

This is the official home for UWP XAML Behaviors on GitHub.
MIT License
702 stars 112 forks source link

Issue #62: Fixed NavigateToPageAction to find INavigate ancestors #63

Closed debonte closed 8 years ago

debonte commented 8 years ago

The problem was NavigateToPageAction's management of sender vs. senderObject in Execute's loop looking for an INavigate implementation. Both implementations (managed and native) had similar problems where the current element's visual parent was found, but wasn't actually analyzed on the next time around the loop.

The fixes in the Execute methods are tiny. The rest of the changes are all about unit testing the managed fix. I didn't invest in unit tests for the native change, but did verify it manually in a test app.

msftclas commented 8 years ago

Hi @debonte, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Erik De Bonte). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

drewgillies commented 8 years ago

Looks great.