search

microsoft / XamlBehaviors

This is the official home for UWP XAML Behaviors on GitHub.
MIT License
702 stars 112 forks source link

Fixed #89: Ensured EventTriggerBehavior supports x:Bind bindings #90

Closed pedrolamas closed 8 years ago

pedrolamas commented 8 years ago

For x:Bind to work with EventTriggerbehavior, we need to ensure that no exception gets raised for not finding the request event on the source object, as this will might (will) get evaluate at a later phase.

So instead of raising an exception, we just gracefully return from the method.

ScottIsAFool commented 8 years ago

LGTM

LocalJoost commented 8 years ago

I agree. I didn't see this at first, but although I do not like silent fails, trading a silent fail that might occur for incorrect exceptions that will almost certainly occur seems like a good one