Updated DesignTools project's output path

microsoft / XamlBehaviorsWpf

Home for WPF XAML Behaviors on GitHub.

MIT License

854 stars 140 forks source link

Updated DesignTools project's output path #131

Closed brianlagunas closed 1 year ago

brianlagunas commented 1 year ago

Description of Change

Modified the build output path of the DesignTools projects from the old net45 to net462 due to the recent framework upgrades.

Bugs Fixed

Related to work done for #102

PR Checklist

[x] Has tests (if omitted, state reason in description)
[x] Rebased on top of master at time of PR
[x] Changes adhere to coding standard

brianlagunas commented 1 year ago

I have an overall concern about the current approach for building the design projects.

@mgoertz-msft can you confirm this is the correct way to output these design assemblies? Do we do something in Azure DevOps to correctly package the design assemblies for each TFM?

mgoertz-msft commented 1 year ago

I guess the validation error may have the answer...

mgoertz-msft commented 1 year ago

@brianlagunas Found it: https://github.com/microsoft/XamlBehaviorsWpf/blob/691f2e448accf844cdb152ed7dbed99b4ef91e1e/src/Microsoft.Xaml.Behaviors/Microsoft.Xaml.Behaviors.csproj#L90

Perhaps we need to put the TFMs we are targeting in a .props file so we don't have to change them in multiple different places

brianlagunas commented 1 year ago

Yeah, I think this is an area that needs improvement. I'll get this fixed so that what we have builds, then look to improve this process in the future.