microsoft / Xbox-GDK-Samples

Game development samples published by the Xbox Advanced Technology Group using the Microsoft GDK.
http://aka.ms/gamedevdocs
MIT License
218 stars 32 forks source link

Errors in Sample::AddUserWithUI #9

Closed OZ1 closed 1 year ago

OZ1 commented 2 years ago

XUserHandle user hides variable from the outer scope: https://github.com/microsoft/Xbox-GDK-Samples/blob/e4d83410b150dbd2d9981f8cbafea530e9cfc4ec/Samples/Live/Fundamentals_Desktop/Fundamentals_Desktop.cpp#L177

resolveAsyncBlock is not used. asyncBlockInner should be replaced to resolveAsyncBlock at #L192 and #L196

I guess deleting asyncBlockInner at #L201 leads to deleting it one more time at L#206

walbourn commented 1 year ago

I believe this warning was fixed some time ago. Let us know if it still repros for you.