microsoft / XmlNotepad

XML Notepad provides a simple intuitive User Interface for browsing and editing XML documents.
https://microsoft.github.io/XmlNotepad/
MIT License
968 stars 207 forks source link

Upgrading leaves old files #328

Closed DustinLuck closed 10 months ago

DustinLuck commented 1 year ago

Observed behavior: Upgrading from v2.8.0.64 to v2.9.0.5 leaves old files behind.

Expected behavior: Files that are no longer needed should be removed.

Steps to reproduce:

  1. Run the v2.9.0.5 installer and choose the location of the installed v2.8.0.64 application.
  2. Copy the application folder to another location.
  3. Unistall v2.9.0.5.
  4. Run the v2.9.0.5 installer.
  5. Compare the files from the backup location in step 2 to the new installation in step 4.

These are the files from the previous version that were not cleaned up:

System Information: Windows 10 Enterprise v21H2 v2.8.0.64 starting point was a portable installation

lovettchris commented 10 months ago

I'm not sure this is a scenario that my setup technology supports, see: https://wixtoolset.org/docs/wix3/

You did not uninstall v2.8.0.64 right? So windows thinks you still have v2.8.0.64 installed, and perhaps these help files belong to that install so that's why they were not removed?

But in general I don't want to support this kind of complexity during setup, the .msi standalone installer is provided as a convenience only for folks that cannot use the ClickOnce or winget installers and .msi is not a technology I want to become an expert in since everyone is moving to .msix, ClickOnce and winget and these newer install technologies solve this problem by always creating a new folder for the new version.