search

microsoft / XmlNotepad

XML Notepad provides a simple intuitive User Interface for browsing and editing XML documents.
https://microsoft.github.io/XmlNotepad/
MIT License
968 stars 207 forks source link

XML Comparison report doesn't show full path of file being compared #332

Closed SeanKilleen closed 10 months ago

SeanKilleen commented 11 months ago

Stumbled across this tool and used it to compare XML files quickly and correctly. Thanks for the time saver!

I noticed that in the HTML output of the comparison report, the file we're comparing to doesn't appear to be listed -- just its directory. Screenshot:

image

I think it's because the XmlDiffBody resource string is defined as:

https://github.com/microsoft/XmlNotepad/blob/67e13a2a77c5be3e951fc7918cea3854190ec8a4/src/XmlNotepad/StringResources.resx#L456-L460

And when called, the directory is what's passed to it:

https://github.com/microsoft/XmlNotepad/blob/67e13a2a77c5be3e951fc7918cea3854190ec8a4/src/Application/FormMain.cs#L2527-L2532

This is just a drive-by issue so I haven't gotten to look into it deeply but figured I'd start by passing it along.

lovettchris commented 11 months ago

Thanks for the bug report.

lovettchris commented 10 months ago

File in editor : {1} is correct, this is picking up sourceXmlFile which is a full path.

Maybe this is fixed in a newer version because this is what I'm seeing:

image