microsoft / XmlNotepad

XML Notepad provides a simple intuitive User Interface for browsing and editing XML documents.
https://microsoft.github.io/XmlNotepad/
MIT License
989 stars 207 forks source link

Multiple instances resets the settings #381

Closed Pierre-de-la-Verre closed 5 months ago

Pierre-de-la-Verre commented 5 months ago

When I open some instances of XMLNotepad, they all use the xmlnotepad.settings. But when I close the instances, some settings are reset to standard value, especially the group of "XMLDiff-settings" and my standard texteditor. I suppose that the refreshing of the settings with "last used files" creates this issue.

lovettchris commented 5 months ago

Hmmm, interesting problem, are you closing lots of windows all at once? I wonder if one is writing while the other is trying to and clobbering the file, causing errors then reverting the file to defaults as a result. if so I will have to think of a solution to this problem... In the meantime giving each one a good second or so before closing might help avoid this issue, let me know if that helps.

Pierre-de-la-Verre commented 5 months ago

I think it's not a time problem, it's an "Option" problem:

lovettchris commented 5 months ago

Great bug, it was a problem in how settings were getting reloaded, this is fixed in https://github.com/microsoft/XmlNotepad/commit/e698427cecf6a3b8e4709b7c8b2a04a6a0279fab and will be in the next update.,

lovettchris commented 5 months ago

Fixed in https://github.com/microsoft/XmlNotepad/releases/tag/2.9.0.9