Add file size safeguard for processed SVG icons

microsoft / YamUI

Reusable component framework for Yammer.com

https://microsoft.github.io/YamUI/

Other

395 stars 40 forks source link

Add file size safeguard for processed SVG icons #229

Open swese44 opened 6 years ago

swese44 commented 6 years ago

We could add file sizes of each generated SVG Icon as a comment in the export in src/components/Icon/icons/index.ts, they'll at least show up in PRs. This might be good as we bring in Illustrations too.

unindented commented 6 years ago

In the new client we're using a glob expression and a max file size, e.g. **/*.svg 8KB. If any file goes over it, the test fails. Maybe setting separate thresholds for icons and illustrations would be good enough?