Open dbjorge opened 1 year ago
This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!
this is a corner case so let's timebox addressing this issue to 4 hours and close if not.
If we do end up closing due to the timebox, we should update our release validation steps accordingly, since validating that this doesn't happen is an explicit part of step 1 from the "Verify 'deprecated page' functionality" release scenario
@madalynrose started working on this in https://github.com/madalynrose/accessibility-insights-web/tree/adhoc-toggles-state-fix, then shelved it for more pressing issues. If someone else picks this up, please discuss with @madalynrose before proceeding.
@madalynrose I am interested in working on this repo, please assign this to me.
Describe the bug
To Reproduce Steps to reproduce the behavior:
CodePen repro example
n/a
Expected behavior
The state of the toggle control should be consistent with whether visualizations are active on the page. I don't think it matters particularly whether the visualization ends up "on" or "off" at the end of these steps, but it shouldn't be self-inconsistent.
Screenshots
Context (please complete the following information)
Are you willing to submit a PR?
yes
Did you search for similar existing issues?
yes
Additional context
found during "Verify deprecated page functionality" validation scenario for 2.36.0, but probably non-blocking (not a regression)