search

microsoft / accessibility-insights-web

Accessibility Insights for Web
https://accessibilityinsights.io
MIT License
837 stars 150 forks source link

ad-hoc visualization state becomes inconsistent after toggling extension off and on #6256

Open dbjorge opened 1 year ago

dbjorge commented 1 year ago

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Activate ad-hoc automated checks on any page with issues
  2. from the browser's manage extension page, toggle the extension off and on
  3. open the popup ad-hoc tools panel 4 note that visualization is not visible on the page, but the toggle control for the automated checks tool is "on"

CodePen repro example

n/a

Expected behavior

The state of the toggle control should be consistent with whether visualizations are active on the page. I don't think it matters particularly whether the visualization ends up "on" or "off" at the end of these steps, but it shouldn't be self-inconsistent.

Screenshots

screenshot of deque mars test page in state where automated checks is toggled on in the ad hoc panel but no failure highlight boxes are visible

Context (please complete the following information)

Are you willing to submit a PR?

yes

Did you search for similar existing issues?

yes

Additional context

found during "Verify deprecated page functionality" validation scenario for 2.36.0, but probably non-blocking (not a regression)

ghost commented 1 year ago

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

ferBonnin commented 1 year ago

this is a corner case so let's timebox addressing this issue to 4 hours and close if not.

dbjorge commented 1 year ago

If we do end up closing due to the timebox, we should update our release validation steps accordingly, since validating that this doesn't happen is an explicit part of step 1 from the "Verify 'deprecated page' functionality" release scenario

DaveTryon commented 1 year ago

@madalynrose started working on this in https://github.com/madalynrose/accessibility-insights-web/tree/adhoc-toggles-state-fix, then shelved it for more pressing issues. If someone else picks this up, please discuss with @madalynrose before proceeding.

thesharifi commented 1 year ago

@madalynrose I am interested in working on this repo, please assign this to me.