microsoft / accessibility-insights-web

Accessibility Insights for Web
https://accessibilityinsights.io
MIT License
841 stars 152 forks source link

[Tracking] AIWeb skips unresponsive iframes #6347

Open sfoslund opened 1 year ago

sfoslund commented 1 year ago

Describe the bug

Our extension makes a best-effort attempt to scan child iframes - we send messages to the child frame and wait for a small timeout. If the child frame does not respond by our timeout, we skip the child iframe. This is a tracking issue for cases when the extension skips child iframes unexpectedly.

If you are running into this issue, please comment below with the following information:

Context

The purpose of this issue is to track all known instances of AI web skipping iframes unexpectedly. It is pointed to in the iframe skipped warning banner, added in https://github.com/microsoft/accessibility-insights-web/pull/6330

ferBonnin commented 1 year ago

we will monitor every week for a month and revisit if needed

gavinbarron commented 1 year ago

This has started to show up as an issue when testing components within our Storybook site for Microsoft Graph Toolkit.

Load this url: https://mgt.dev/?path=/story/components-mgt-agenda--simple Wait for the page to load and then run a FastPass scan.

OS: Windows 11 Enterprise Version: 22H2 Build: 22621.1702

AI-Web Version: 2.38.1

Browser: Microsoft Edge for Business Version 114.0.1823.30 (Official build) beta (64-bit)

Is there any known work arounds I could look into?

DaveTryon commented 1 year ago

Hi, @gavinbarron! We've looked into this, and StoryBook's IFrames can't be scanned by Accessibility Insights for Web. StoryBook is sort of an artificial hosting environment, so we don't recommend it as a test bed for assessing the accessibility of your controls. You'll get a much more meaningful result by hosting your control in a simple test page and scanning that page using Accessibility Insights for Web.

As an alternative, StoryBook has an accessibility add-on that is intended to provide accessibility testing within StoryBook. This add-on is based on axe-core (the same engine used by Accessibility Insights for Web), but because it uses a 2020 version of axe-core, its results may be somewhat behind current WCAG standards.

Thanks for using Accessibility Insights!

TaliHausner commented 1 year ago

Hi,

  1. Steps to reproduce the behavior -can't run the accessibility insight tool with fast pass on my react blade
  2. A target site URL or code pen repro example - https://ms.portal.azure.com/?feature.securityGraphDebug=true%2F#view/Microsoft_Azure_Security/SecurityMenuBlade/~/AscInformationProtection
  3. OS Name & Version (e.g. Windows 10.0.18363 Build 18363 / macOS Catalina 10.15(19A583)) - windows 11 enterprise
  4. AI-Web Version & Environment (e.g. 1.140.1 Insider)
  5. Browser Version (e.g. Google Chrome 78.0.3904.108 (Official Build) (64-bit)) - not working in chrome and in edge browsers
  6. [Optional] Screenshots, additional context screenshots of the blade and the error:

dsdsdsdsdsdsd

Screenshot 2023-11-15 125334

gardnerjr commented 2 months ago

@TaliHausner did you ever get more followup on this? we are now seeing this in some of our reactview blades in the azure portal as well