search

microsoft / accessibility-insights-web

Accessibility Insights for Web
https://accessibilityinsights.io
MIT License
835 stars 150 forks source link

chore: Typescript Cleanup- Part 1 of 3 #7255

Closed SaanicaG closed 7 months ago

SaanicaG commented 7 months ago

Details

As part of Typescript migration added/removed the error causing fields.

  1. src/DetailsView/components/details-view-content.tsx

    • For the above file we were getting errors on getOverviewHeadingIntro, linkDataSource, getOverviewHelpSectionAbout these properties.
    • These properties are referred in details-view-switcher-nav.ts, overview-content-container.tsx.
    • Hence, we are not removing these properties, and added it in details-view-body.tsx.

  2. src/DetailsView/components/details-view-overlay/scoping-panel/scoping-panel.tsx

    • We were getting error on deps={this.props.deps}.
    • In details-view-overlay.tsx class ScopingPanel is used.
    • Hence, we are not removing these properties and added it in scoping-container.tsx

  3. Details-view-switcher-nav.ts

    • Got error on shouldShowQuickAssessRequirementView: true,
    • Couldn’t find any reference to the above property in any of the files.
    • Tested it after removing the property. There are no errors and also on UI level couldnt find any issues. -Hence, it seems like it is safe to remove it.
      Motivation

      TypeScript 5.0 has marked some options as deprecated. We can temporarily override these deprecations, but the documented plan is for the ability to override the flag to go away in TypeScript 5.5

Associated User story - User Story 2151430

Context

Pull request checklist