search

microsoft / accessibility-insights-web

Accessibility Insights for Web
https://accessibilityinsights.io
MIT License
835 stars 150 forks source link

chore: Typescript Cleanup Part 2 of 3 for selector, isEnabled, requirementLink, leftNavLinkBuilder & height:0 #7276

Closed v-prachin closed 6 months ago

v-prachin commented 7 months ago

Details

Typescript Cleanup Part 2 of 3 We have total 140 errors in 104 files. Thus, targeting each error and fixing it.

Motivation

Errors observed in below files observed after removing deprecated properties from tsconfig file:

1 renderRequirementDescription: requirementLink =>
src/assessments/automated-checks/build-test-steps-from-rules.tsx No. Of Error: 1 Removed this property based on this PR: https://github.com/microsoft/accessibility-insights-web/pull/3163

2.selector: selector
src/background/assessment-data-converter.ts No. Of Error: 1 Added the property in the interface

3.selector: selectorStub
src/tests/unit/tests/background/assessment-data-converter.test.ts No. Of Error: 3 Added the property in the interface

4.isEnabled: true
src/assessments/cognitive/assessment src/assessments/headings/assessment.tsx src/assessments/parsing/assessment.tsx No. Of Error: 3 Added the property in the interface.

5.leftNavLinkBuilder: leftNavLinkBuilderMock.object src/tests/unit/tests/DetailsView/components/left-nav/assessment-left-nav.test.tsx No. Of Error: 1

6.leftNavLinkBuilder: leftNavLinkBuilderMock.object src/tests/unit/tests/DetailsView/components/left-nav/quick-assess-left-nav.test.tsx No. Of Error: 1

7.leftNavLinkBuilder: leftNavLinkBuilderMock.object src/tests/unit/tests/DetailsView/components/left-nav/visualization-based-left-nav.test.tsx No. Of Error: 1

8.height: 0 src/tests/unit/tests/DetailsView/components/narrow-mode-detector.test.tsx No. Of Error: 1 This property is not present in the main file, thus removed it from the test file.

Thus, total number of errors covered as part of this user story: 12

Context

Pull request checklist