microsoft / accessibility-insights-web

Accessibility Insights for Web
https://accessibilityinsights.io
MIT License
835 stars 150 forks source link

chore: Typescript Cleanup Part 2 of 3 for rule: ruleStub & launchPanelType: panelType #7289

Closed v-prachin closed 6 months ago

v-prachin commented 6 months ago

Details

Typescript Cleanup Part 2 of 3 We have total 140 errors in 104 files. Thus, targeting each error and fixing it.

Motivation

Errors observed in below files observed after removing deprecated properties from tsconfig file: 1.rule: ruleStub
src/tests/unit/tests/injected/element-based-view-model-creator.test.ts (9) scanNodeResults consists of unified results as well as ruleStub. So, using scanNodeResults to resolve the issue.

2.launchPanelType: panelType
src/popup/actions/popup-action-message-creator.ts(1) src/tests/unit/tests/popup/actions/popup-action-message-creator.test.ts(1) Added new type LaunchPanelTelemetryData in extension-telemetry-events.ts, to resolve the error for launchPanelType: panelType

Thus, total number of errors covered as part of this user story: 11

Context

Pull request checklist