microsoft / accessibility-insights-web

Accessibility Insights for Web
https://accessibilityinsights.io
MIT License
820 stars 146 forks source link

False positive? Ensure elements that have scrollable content are accessible by keyboard #7338

Open jzazo opened 2 months ago

jzazo commented 2 months ago

Describe the bug

I am running the accessibility report extension and I get flagged an error: scrollable-region-focusable: Elements with scrollable content must be accessible by keyboard. It affects the search box, enabled via plugin.

Path: .md-search__scrollwrap

Snippet:
- <div class="md-search__scrollwrap"> <div class="md-search-result" data-md-component="search-result">
- <div class="md-search-result__meta">Type to start searching</div> <ol class="md-search-result__list" role="presentation"></ol> </div> 

Fix ONE of the following:
- Element should have focusable content
- Element should be focusable

Adding a tabindex="0" to the div section <div class="md-search__scrollwrap"> removes the error.

However, I created this issue in the material-mkdocs project and you can navigate search results with the keyboard, and the author claims that the flag is a false positive.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://microsoft.github.io/rats/
  2. Run the accessibility-insights-web extension. The error relates to the search box. If you search commands you can scroll through results, so the error is probably a false positive.

Expected behavior

If this is a false positive, an error should not be flagged.

Screenshots

Screenshot 2024-05-18 145934 Screenshot 2024-05-18 145955

Context (please complete the following information)

Are you willing to submit a PR?

No.

Did you search for similar existing issues?

Yes.

microsoft-github-policy-service[bot] commented 2 months ago

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

v-viyada commented 2 months ago

@jzazo We have opened https://github.com/dequelabs/axe-core/issues/4470 for axe-core. We will update in the extension once we have fix from upstream. Thanks