For nav-link-button.tsx & nav-link-button.test,tsx only issue noticed is about indentation in the Left Nav, which as suspected is due to use of v9 Link component in v8 Nav component. Thus, when nav is migrated we can migrate the Link component in it.
UI locations for all the files are mentioned with images below:
Details
Link component migration from v8 to v9
Motivation
Files worked upon: 1.launch-pad-item-row.tsx & launch-pad-item-row.test.tsx 2.ad-hoc-tools-panel.tsx & ad-hoc-tools-panel.test.tsx 3.diagnostic-view-toggle.tsx & diagnostic-view-toggle.test.tsx 4.tab-stops-requirement-instances-collapsible-content.tsx & tab-stops-requirement-instances-collapsible-content.test.tsx 5.iframe-warning.tsx & iframe-warning.test.tsx 6.new-tab-link.tsx & new-tab-link.test.tsx 7.failure-instance-panel-control.tsx & failure-instance-panel-control.test.tsx 8.assessment-instance-edit-and-remove-control.tsx & assessment-instance-edit-and-remove-control.test.tsx
Visible changes in UI observed & have added those changes in this Document. Data for UI testing carried out in both normal & high contrast modes is present here. https://microsoft-my.sharepoint.com/:w:/p/v-prachin/EfJ0ufVhMP5AqLEJ8Y9hLh4Bs55kWMuCHCDR-hdUcinfiA?e=0IFOCm
Context
For nav-link-button.tsx & nav-link-button.test,tsx only issue noticed is about indentation in the Left Nav, which as suspected is due to use of v9 Link component in v8 Nav component. Thus, when nav is migrated we can migrate the Link component in it.
UI locations for all the files are mentioned with images below:
2.ad-hoc-tools-panel.tsx
3.tab-stops-requirement-instances-collapsible-content.tsx
4.new-tab-link.tsx
5.failure-instance-panel-control.tsx
6.assessment-instance-edit-and-remove-control.tsx
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.