search

microsoft / adme-samples

MIT License
11 stars 19 forks source link

Storage API - duplicate header definition #84

Open gukoff opened 1 month ago

gukoff commented 1 month ago

Problem

OpenAPI spec of the PATCH /records endpoint contains a duplicate header.

Example for M18: https://github.com/microsoft/adme-samples/blob/ec8b7e7830d3472d273d608847158779f8de18c1/rest-apis/M18/storage_openapi.yaml#L787-L798

Screenshots

image image
gukoff commented 1 month ago

@abms26 @cmonginmsft I believe something's wrong with the "Automate swagger doc update" job.

short-term fix: https://github.com/microsoft/adme-samples/pull/85

abms26 commented 1 month ago

Hi @gukoff, Thanks for identifying this in the swagger spec. I will approve this PR and merge. The problem is not in the job but rather in the API spec that is generated by the spring doc plugin of the storage service.

@romica request you to please make a note of this - the service controller code needs some changes for the swagger spec to be generated correctly. This might resurface again in the M23 service code as well. Thanks!