search

microsoft / aerial_wildlife_detection

Tools for detecting wildlife in aerial images using active learning
MIT License
224 stars 58 forks source link

Datatabase schema is not set #34

Open frafra opened 3 years ago

frafra commented 3 years ago

Database schema is required by this script:

https://github.com/microsoft/aerial_wildlife_detection/blob/de150d03e267676876554f62188689cf4196f4bb/projectCreation/import_images.py#L50

Missing from:

https://github.com/microsoft/aerial_wildlife_detection/blob/de150d03e267676876554f62188689cf4196f4bb/config/settings.ini#L127-L140

I would also suggest raising an error if the parameter is mandatory but missing.

schema should be equal to the user name.

bkellenb commented 3 years ago

Thank you very much for this issue. This is a legacy script that originates to AIDE version 1.0 where only one "project" could be supported at a time (and had to be specified in the settings.ini file, precisely through the schema keyword). With AIDE version 2.0, this keyword has become obsolete as an arbitrary number of projects can now be created.

I have resolved the issue in the latest commit (and also removed the SQL injection vulnerability mentioned in the respective issue). The same holds for the file in the latest development branch.