search

microsoft / aerial_wildlife_detection

Tools for detecting wildlife in aerial images using active learning
MIT License
230 stars 58 forks source link

kombu.five has been dropped from Kombu 5.0.0 and greater #36

Closed frafra closed 3 years ago

frafra commented 3 years ago

https://github.com/microsoft/aerial_wildlife_detection/blob/de150d03e267676876554f62188689cf4196f4bb/modules/AIController/backend/messageProcessor.py#L30

https://docs.celeryproject.org/projects/kombu/en/stable/changelog.html#version-5-0-0

kombu==4.6.11 should be added to the requirements until the old Python 2 code is dropped.

bkellenb commented 3 years ago

Hi,

Thanks for raising the issue. In fact the only dependency on kombu.five was the use of the monotonic time clock, but the official Kombu documentation sees this replaced with time.monotonic() anyway. The latest commit #54e4662 therefore sees kombu dropped from the requirements list (it's automatically installed by Celery). I also removed the version specifier for Celery. A quick test with a new Conda environment showed no conflicts, but should any more issues arise I can re-introduce the version requirement.