microsoft / agogosml

agogosml is a flexible data processing pipeline that addresses the common need for operationalizing ML models at scale
MIT License
33 stars 16 forks source link

Update pyyaml #239

Closed c-w closed 5 years ago

c-w commented 5 years ago

Versions below 4.2b1 suffer from CVE-2017-18342. The tests still pass so this should be a safe update.

All Submissions:

sayar commented 5 years ago

This is a temporary fix and won't resolve the underlying issue; every time pipenv update is run, the Pipfile.lock will revert back to pyyaml below 4.2b1. See #232

c-w commented 5 years ago

What's worse, when I apply this diff:

--- a/agogosml_cli/Pipfile
+++ b/agogosml_cli/Pipfile
@@ -6,6 +6,7 @@ verify_ssl = true
 bumpversion = "*"
 wheel = "*"
 watchdog = "*"
+pyyaml = ">=4.2b1"  # transitive dependency via watchdog has a vulnerability
 flake8 = "*"
 tox = "*"
 pytest = "*"
@@ -27,3 +28,6 @@ cookiecutter = "~=1.6"

 [requires]
 python_version = "3.7"
+
+[pipenv]
+allow_prereleases = true

Then jsonnet build starts failing for some reason... And here I thought pipenv was supposed to fix this.