Closed c-w closed 5 years ago
Integration tested via:
docker network create redis-test docker build --target builder -t agogosml -f agogosml/Dockerfile.agogosml agogosml docker run -d --name redis --rm --network redis-test -p 6379:6379 redis:5-alpine \ redis-server --requirepass 123456password docker run -d --rm --network redis-test -it agogosml \ python -m agogosml.tools.receiver --receiver redis \ '{"REDIS_URL":"redis://:123456password@redis:6379", "REDIS_CHANNEL":"mychan"}' docker run -d --rm --network redis-test -it agogosml \ python -m agogosml.tools.sender --infile README.rst --sender redis \ '{"REDIS_URL":"redis://:123456password@redis:6379", "REDIS_CHANNEL":"mychan"}' docker logs -f <id-of-receiver-container>
[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Does your PR follow our Code of Conduct?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.
[x] Is this code designed to be testable?
[x] Is the code documented well?
[x] Does your submission pass existing tests (or update existing tests with documentation regarding the change)?
[x] Have you added tests to cover your changes?
[x] Have you linted your code prior to submission?
[x] Have you updated the documentation and README?
[x] Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).
[x] Have secrets been stripped before committing?
Integration tested via:
All Submissions:
[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Does your PR follow our Code of Conduct?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.
[x] Is this code designed to be testable?
[x] Is the code documented well?
[x] Does your submission pass existing tests (or update existing tests with documentation regarding the change)?
[x] Have you added tests to cover your changes?
[x] Have you linted your code prior to submission?
[x] Have you updated the documentation and README?
[x] Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).
[x] Have secrets been stripped before committing?