microsoft / agogosml

agogosml is a flexible data processing pipeline that addresses the common need for operationalizing ML models at scale
MIT License
34 stars 16 forks source link

Pin agogosml library version in cli output #284

Closed sayar closed 5 years ago

sayar commented 5 years ago

All Submissions:

cicorias commented 5 years ago

this seems to only ensure that agogosml is at a specific version - which is good and generally this would dictate that semantic versioning is followed. although using 0.xx as a versioning strategy probably should be avoided and just start with 1.x - and start pushing major version updates when things WILL break - which is now often. exact version in requirements (==) always imho work best.

sayar commented 5 years ago

this seems to only ensure that agogosml is at a specific version - which is good and generally this would dictate that semantic versioning is followed. although using 0.xx as a versioning strategy probably should be avoided and just start with 1.x - and start pushing major version updates when things WILL break - which is now often. exact version in requirements (==) always imho work best.

I agree so I'm pinning to exact major.minor versions. Patches are still picked up this way.