Closed margaretmeehan closed 5 years ago
[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Does your PR follow our Code of Conduct?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.
[ ] Is this code designed to be testable?
[ ] Is the code documented well?
[ ] Does your submission pass existing tests (or update existing tests with documentation regarding the change)?
[ ] Have you added tests to cover your changes?
[ ] Have you linted your code prior to submission?
[ ] Have you updated the documentation and README?
[ ] Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).
[ ] Have secrets been stripped before committing?
All Submissions:
[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Does your PR follow our Code of Conduct?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.
[ ] Is this code designed to be testable?
[ ] Is the code documented well?
[ ] Does your submission pass existing tests (or update existing tests with documentation regarding the change)?
[ ] Have you added tests to cover your changes?
[ ] Have you linted your code prior to submission?
[ ] Have you updated the documentation and README?
[ ] Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).
[ ] Have secrets been stripped before committing?