search

microsoft / alguidelines

Best Practices and Design Patterns for the AL Language
https://alguidelines.dev/
MIT License
129 stars 48 forks source link

Support devcontainer (local and GH Codespaces) #143

Closed tfenster closed 2 years ago

tfenster commented 2 years ago

As an alternative to locally installing the toolset, you can also use a devcontainer. This PR adds the required files and documentation how to use it.

tfenster commented 2 years ago

@waldo1001 @JeremyVyska as discussed today :)

ajkauffmann commented 2 years ago

@tfenster This requires a switch to Linux containers. Doesn't that mean you can't run Business Central containers at the same time? It's not described, but if that is the case, you might want to add that.

tfenster commented 2 years ago

@tfenster This requires a switch to Linux containers. Doesn't that mean you can't run Business Central containers at the same time? It's not described, but if that is the case, you might want to add that.

Good point, but no, the Windows containers keep running, you just can't manage them through Docker Desktop anymore.

image

TheDoubleH commented 2 years ago

@tfenster / @ajkauffmann

Might be an idea to add a warning about that.


{{% alert title="Warning" color="warning" %}}
Blah Blah Blah
{{% /alert %}}
tfenster commented 2 years ago

@tfenster / @ajkauffmann

Might be an idea to add a warning about that.

{{% alert title="Warning" color="warning" %}}
Blah Blah Blah
{{% /alert %}}

You mean a warning about the switch to Linux? The message in the screenshot above appears in Docker Desktop, not sure if it makes sense to add more or what more I would be able to add? But of course, if you have an idea, happy to add anything

TheDoubleH commented 2 years ago

@tfenster I don't know if many people has as much experience as You when it comes to Docker.

I know my initial reaction would be "UH oh" and then panic.

If you can add a message about to not be concerned if / when you get that.

tfenster commented 2 years ago

If you can add a message about to not be concerned if / when you get that.

@TheDoubleH I added something, see https://github.com/microsoft/alguidelines/pull/143/commits/cda4104e6189611866a03e0ab0c31d751712e411. Does that make sense and helps to avoid the concerns? Or is it too much?

tfenster commented 2 years ago

@waldo1001 as discussed: https://github.com/microsoft/alguidelines/pull/143/commits/408368b3de51e324d78c874d51761f606e33a6e2