search

microsoft / angle

ANGLE: OpenGL ES to DirectX translation
Other
615 stars 166 forks source link

Holographic transform mirror hack is causing shading bugs #132

Open mlfarrell opened 7 years ago

mlfarrell commented 7 years ago

Behold, my latest hack removal target:

                // TODO: The display was being mirrored, so for now we hack these values to 
                //       negative as far as the app is concerned.
                viewTransform.Left.M11 = -viewTransform.Left.M11;
                viewTransform.Left.M12 = -viewTransform.Left.M12;
                viewTransform.Left.M13 = -viewTransform.Left.M13;
                viewTransform.Right.M11 = -viewTransform.Right.M11;
                viewTransform.Right.M12 = -viewTransform.Right.M12;
                viewTransform.Right.M13 = -viewTransform.Right.M13;
                mMidViewMatrix._11 = -mMidViewMatrix._11;
                mMidViewMatrix._12 = -mMidViewMatrix._12;
                mMidViewMatrix._13 = -mMidViewMatrix._13;

This is causing gl_FrontFacing to be incorrectly mirrored w.r.t the x axis in all of my shaders. Is there a better way to handle this?

mlfarrell commented 7 years ago

Oddly enough, commenting this has no effect on my shading at all. So less critical issue, but would be good to phase out the above code entirely still..