search

microsoft / angle

ANGLE: OpenGL ES to DirectX translation
Other
615 stars 166 forks source link

Override GL_ALPHA texformats for FL9.3 to fix mipmaps #33

Closed abmantis closed 9 years ago

abmantis commented 9 years ago

Feature level 9.3 does not allow mipmaps for DXGI_FORMAT_A8_UNORM textures, so we need to use DXGI_FORMAT_R8G8B8A8_UNORM.

This could be improved so that the override is only performed for textures with mipmaps.

This override was also present in the old winrt branch.

austinkinross commented 9 years ago

Hi abmantis,

Thanks a lot for your contribution and your interest in ANGLE! We have been aware of this issue for a while, so it'll be great to have a fix.

However, we are unable to take contributions directly to our repository at this time. Instead, we ask that you submit your change to Google's master ANGLE repository (which can be found here: https://code.google.com/p/angleproject/). We regularly merge the master ANGLE branch into our ms-master branch on GitHub, so if you submit your change to master then it will be available in ms-master shortly afterwards.

If you submit your change to Google's master repository then I can help to code-review your change over there.

Thanks again, Austin

austinkinross commented 9 years ago

Hi,

A fix for this issue has been pushed to Google's master ANGLE repository, and it was merged into our ms-master branch this morning.

Thank you for your interest in ANGLE. If you're interested in making a contribution to ANGLE in the future then we'd love to see it, but you should submit the change directly to Google's master repository.

Thanks again, Austin

abmantis commented 9 years ago

Hello Austin,

I'm sorry that I wasn't able to submit it to Google's repository but, I haven't yet been able to complete the contributor requirements.

Anyway, thank you for letting me know that a fix has been pushed.

Best regards, Abílio Costa.

Hi,

A fix for this issue has been pushed to Google's master ANGLE repository, and it was merged into our ms-master branch this morning.

Thank you for your interest in ANGLE. If you're interested in making a contribution to ANGLE in the future then we'd love to see it, but you should submit the change directly to Google's master repository.

Thanks again, Austin

— Reply to this email directly or view it on GitHub https://github.com/MSOpenTech/angle/pull/33#issuecomment-88160366.