microsoft / app-store-vsts-extension

Visual Studio Team Services (VSTS) extension for performing continuous delivery to the App Store store from your automated CI builds
Other
95 stars 53 forks source link

Submitting already uploaded binary for Apple Review fails because "No deliver configuration found in the current directory." #230

Open SEnglishSMP opened 3 years ago

SEnglishSMP commented 3 years ago

Required Information

Entering this information will route you directly to the right team and expedite traction.

Question, Bug, or Feature?
Type: Bug

Enter Task Name: Apple App Store Release

Environment

Issue Description

A previous stage in our release pipeline uploads the app to TestFlight. The one in question then adds metadata and submits the already uploaded binary for review by Apple. This used to work.

Due to Apple's requirement for 2FA, we instead turned to using an API key. According to Fastlane documentation, API keys are fully supported for deliver and this task has a way to configure that, so it should work. The previous stage (uploading to TestFlight) still works correctly (now that we're using an API key), but submitting to Apple Review fails. The logs show:

[19:47:15]: No deliver configuration found in the current directory. Do you want to setup deliver?

...after which the process tanks because it's not running in interactive mode.

The error indicates that Fastlane is not being called correctly. This may be related to #206, however the use of API keys differs as does the error messages returned, so I'm opening a new ticket. Note that we are providing metadata.

The YAML provided by the UI is below. I've replaced the app identifier with "[...]".

steps:
- task: ms-vsclient.app-store.app-store-release.AppStoreRelease@1
  displayName: 'Submit app for Review'
  inputs:
    authType: ApiKey
    apiKeyId: '$(AppStoreConnectAPIKeyID)'
    apiKeyIssuerId: '$(AppStoreConnectAPIKeyIssuerID)'
    apitoken: '$(AppStoreConnectAPIKeyContent)'
    appIdentifier: [...]
    releaseTrack: Production
    skipBinaryUpload: true
    uploadMetadata: true
    metadataPath: '$(System.DefaultWorkingDirectory)/_iOS release/drop/AppStore/metadata'
    shouldSubmitForReview: true
    fastlaneArguments: '--submission_information "{\"add_id_info_uses_idfa\": false}"'

Task logs

NOTE: I've replaced potentially sensitive information with "..." in the logs. ReleaseLogs_305.zip

Error logs

[19:47:15]: No deliver configuration found in the current directory. Do you want to setup deliver?
anatolybolshakov commented 3 years ago

Hi @SEnglishSMP this seems to be related to a fastlane issue https://github.com/fastlane/fastlane/issues/18321 (which was opened after https://github.com/microsoft/app-store-vsts-extension/issues/206)

frankfuu commented 3 years ago

Agreed. Hopefully this can be fixed soon. Not able to complete my CI/CD workflow for my mobile apps without this.