microsoft / app-store-vsts-extension

Visual Studio Team Services (VSTS) extension for performing continuous delivery to the App Store store from your automated CI builds
Other
95 stars 53 forks source link

Is this warning message needed: "You specified releaseNotes - so you need to provide fastlane session, app specific password only won't work" #289

Open syewchuk opened 1 year ago

syewchuk commented 1 year ago

Required Information

Entering this information will route you directly to the right team and expedite traction.

Question, Bug, or Feature?
Type: Bug/Feature

Enter Task Name: AppStoreRelease@1

list here (V# not needed):
https://github.com/microsoft/app-store-vsts-extension/tree/master/Tasks/AppStoreRelease https://github.com/microsoft/app-store-vsts-extension/blob/master/Tasks/AppStoreRelease/app-store-release.ts

Environment

Issue Description

I am always getting this warning message even though I can upload release notes without issue:

"##[warning]You specified releaseNotes - so you need to provide fastlane session, app specific password only won't work"

I do not think I should get this warning message since the release notes are uploaded without issue.

The error message is coming from this line in app-store-release.ts:

292                if (usingReleaseNotes) {
293                    if (!credentials.fastlaneSession) {
294                        tl.warning(tl.loc('ReleaseNotesRequiresFastlaneSession'));
295                    }
296
297                    pilotCommand.arg(['--changelog', fs.readFileSync(releaseNotes).toString()]);
298                }

Perhaps this message is a vestige from before API key authentication was added? Or maybe fastlane has changed?

appstore_release_task_logs.txt

LiliaSabitova commented 1 year ago

Hi @syewchuk thank you for reporting the issue. Yes, look like this warning is a vestige. We'll get back to it as soon as we have enough capacity.

rmorrin commented 1 year ago

Is there any progress on this issue? We're seeing the same warning and also using API key for authentication. Release notes are updated without any problems.

LiliaSabitova commented 1 year ago

Hi @rmorrin, I'm working on this issue now.

LiliaSabitova commented 1 year ago

Merged changes to master.